SuccessChanges

Summary

  1. Deployer pod may be unable to observe started pod from API (commit: f347877) (details)
Commit f3478775aa6a39d0f551ae770bca42f673a460b3 by Clayton Coleman
Deployer pod may be unable to observe started pod from API
The code in the deployer pod may reach the lifecycle hook execution
prior to the kubelet being able to update the pod status to "running"
with a valid start time. This caused the deployer pod to panic because
start time was empty.
Since the window for this race is small, if the deployer pod can't see a
start time it can use `time.Now()` to bound the expiration window. Since
the process is reentrant, we can't use a start time at the beginning of
the deployer process (it's no more accurate that way).
A future change should guarantee the start time is available to the
container (via downward API, probably).
(commit: f347877)
The file was modifiedpkg/deploy/strategy/support/lifecycle_test.go (diff)
The file was modifiedpkg/deploy/strategy/support/lifecycle.go (diff)